conditionally republish video on resume#388
Open
luukschipperheyn wants to merge 1 commit intoblackuy:masterfrom
Open
conditionally republish video on resume#388luukschipperheyn wants to merge 1 commit intoblackuy:masterfrom
luukschipperheyn wants to merge 1 commit intoblackuy:masterfrom
Conversation
slycoder
suggested changes
Oct 4, 2020
Collaborator
slycoder
left a comment
slycoder
left a comment
There was a problem hiding this comment.
Cool, this seems like a good fix but the video gets published by default in onConnected so you'll need to set isLocalVideoPublished there as well.
gastonmorixe
force-pushed
the
master
branch
from
7c3cd06 to
bce7e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When app returns from background, video should only be republished if it was published before.
Unconditionally publishing video upon returning to the app can be unwanted behavior for apps that need local video to be unpublished.